[Asterisk-code-review] Add primitive SFU support to bridge softmix. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5643 )

Change subject: Add primitive SFU support to bridge_softmix.
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5643/8/bridges/bridge_softmix.c
File bridges/bridge_softmix.c:

PS8, Line 535: 		if (ast_stream_topology_append_stream(dest, clone) < 0) {
             : 			ast_stream_free(clone);
             : 		}
We should be returning -1 here too.


Line 595: 	ast_stream_topology_free(joiner_topology);
joiner_topology is double freed.  Once here and once when we reach the cleanup label.


-- 
To view, visit https://gerrit.asterisk.org/5643
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c44a829cc63acf8b596a337b2dc3c13898a6c4d
Gerrit-PatchSet: 8
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes