[Asterisk-code-review] testsuite: Add delays to pjsip/ami registration tests (testsuite[master])

George Joseph asteriskteam at digium.com
Thu May 25 13:17:50 CDT 2017


George Joseph has submitted this change and it was merged. ( https://gerrit.asterisk.org/5720 )

Change subject: testsuite:  Add delays to pjsip/ami registration tests
......................................................................


testsuite:  Add delays to pjsip/ami registration tests

The sipp scenarios for show_registration_inbound_contact_statuses
and show_registrations_inbound sent a REGISTER and waited for
an OK but then ended sometimes causing the tests to fail because
there wasn't enough time to receive the AMI events they're
testing for.

Added a 3 second delay after the receipt of the OK to keep the
scenario alive long enough to capture the events.

Change-Id: I29821cc81509a54c1a234507ee22c86dbceac436
---
M tests/channels/pjsip/ami/show_registration_inbound_contact_statuses/sipp/register.xml
M tests/channels/pjsip/ami/show_registrations_inbound/sipp/register.xml
2 files changed, 4 insertions(+), 0 deletions(-)

Approvals:
  George Joseph: Looks good to me, approved; Approved for Submit
  Jenkins2: Verified



diff --git a/tests/channels/pjsip/ami/show_registration_inbound_contact_statuses/sipp/register.xml b/tests/channels/pjsip/ami/show_registration_inbound_contact_statuses/sipp/register.xml
index a336fcd..66edc79 100644
--- a/tests/channels/pjsip/ami/show_registration_inbound_contact_statuses/sipp/register.xml
+++ b/tests/channels/pjsip/ami/show_registration_inbound_contact_statuses/sipp/register.xml
@@ -21,4 +21,6 @@
     </send>
 
     <recv response="200" rtd="true" />
+
+    <pause milliseconds="3000"/>
 </scenario>
diff --git a/tests/channels/pjsip/ami/show_registrations_inbound/sipp/register.xml b/tests/channels/pjsip/ami/show_registrations_inbound/sipp/register.xml
index 14ce6ba..59bb383 100644
--- a/tests/channels/pjsip/ami/show_registrations_inbound/sipp/register.xml
+++ b/tests/channels/pjsip/ami/show_registrations_inbound/sipp/register.xml
@@ -20,4 +20,6 @@
     </send>
 
     <recv response="200" rtd="true" />
+
+    <pause milliseconds="3000"/>
 </scenario>

-- 
To view, visit https://gerrit.asterisk.org/5720
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I29821cc81509a54c1a234507ee22c86dbceac436
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list