[Asterisk-code-review] Sqlite3: make busy timeout configurable. (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5695 )

Change subject: Sqlite3: make busy_timeout configurable.
......................................................................


Patch Set 3:

(3 comments)

A few minor output things, but otherwise this looks good to me.

https://gerrit.asterisk.org/#/c/5695/3/cdr/cdr_sqlite3_custom.c
File cdr/cdr_sqlite3_custom.c:

Line 188: 			ast_log(LOG_WARNING, "Invalid value of %s:busy_timeout. Using default 1000.\n", config_file);
I think a warning is fine. I would change the text to:

 ast_log(LOG_WARNING, "Invalid busy_timeout value '%s' specified. Using 1000 instead.\n", tmp);


https://gerrit.asterisk.org/#/c/5695/3/cel/cel_sqlite3_custom.c
File cel/cel_sqlite3_custom.c:

Line 194: 			ast_log(LOG_WARNING, "Invalid value of %s:busy_timeout. Using default 1000.\n", config_file);
Change the text to:

 ast_log(LOG_WARNING, "Invalid busy_timeout value '%s' specified. Using 1000 instead.\n", tmp);


https://gerrit.asterisk.org/#/c/5695/3/res/res_config_sqlite3.c
File res/res_config_sqlite3.c:

Line 417: 				ast_log(LOG_WARNING, "Invalid value of res_config_sqlite3.conf:busy_timeout. Using default 1000.\n");
I would change this to:

 ast_log(LOG_WARNING, "Invalid busy_timeout value '%s' at res_config_sqlite3.conf:%d. Using 1000 instead.\n", var->value, var->lineno);


-- 
To view, visit https://gerrit.asterisk.org/5695
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8921a3aac3c335843be4cb17d2dd0a5c157a36da
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes