[Asterisk-code-review] Sqlite3: make busy timeout configurable. (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5695 )

Change subject: Sqlite3: make busy_timeout configurable.
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/5695/1/cdr/cdr_sqlite3_custom.c
File cdr/cdr_sqlite3_custom.c:

Line 187: 		busy_timeout = atoi(tmp);
Use strtol instead of atoi so that you can check for errors. If you encounter an error, emit an error message and set busy_timeout to the default value (1000).


https://gerrit.asterisk.org/#/c/5695/1/cel/cel_sqlite3_custom.c
File cel/cel_sqlite3_custom.c:

Line 193: 		busy_timeout = atoi(tmp);
Use strtol instead of atoi so that you can check for errors. If you encounter an error, emit an error message and set busy_timeout to the default value (1000).


https://gerrit.asterisk.org/#/c/5695/1/configs/samples/res_config_sqlite3.conf.sample
File configs/samples/res_config_sqlite3.conf.sample:

Line 33: ;busy_timeout=1000
Add a blank line (with a leading semicolon) before this line to match the rest of the file.


-- 
To view, visit https://gerrit.asterisk.org/5695
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8921a3aac3c335843be4cb17d2dd0a5c157a36da
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes