[Asterisk-code-review] chan sip: Better ICE handling for RTCP-MUX (asterisk[13])

[Stefan Engström]

Stefan Engström has posted comments on this change. ( https://gerrit.asterisk.org/5650 )

Change subject: chan_sip: Better ICE handling for RTCP-MUX
......................................................................


Patch Set 2:

I'm not sure about the part of not emitting RTCP ICE candidates on offers generated from chan sip peers that have rtcp_mux... This makes it required for all 'rtcp_mux=yes' peers/clients to actually support rtcp_mux which it is not now. Do we know of any concrete problem with offering "optional rtcp mux" as in rtcp_mux + rtcp ice candidates, besides the future problem of communicating with unpatched 13.15 asterisks?

-- 
To view, visit https://gerrit.asterisk.org/5650
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeaf47e83972fe8dbe58b7fb3d6d1823400cfb91
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Stefan Engström <stefanen at kth.se>
Gerrit-HasComments: No