[Asterisk-code-review] app queue: Add QUEUE FLOAT PENALTY feature (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/5623 )

Change subject: app_queue: Add QUEUE_FLOAT_PENALTY feature
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5623/1/configs/samples/queuerules.conf.sample
File configs/samples/queuerules.conf.sample:

PS1, Line 24: If QUEUE_FLOAT_PENALTY is set, agents with a lower penalty will be treated as having a penalty = QUEUE_FLOAT_PENALTY.
In this context the word FLOAT to me implies modifying the member penalty in a bidirectional way whereas the option is only unidirectional (in this case "up").

Because of that I think I'd prefer this variable to be renamed to something like QUEUE_RAISE_PENALTY. Then it is a little clearer as to what's happening:

"if QUEUE_RAISE_PENALTY is set, agents with a lower penalty have their penalty temporarily raised to the value specified."

Then there could even be a QUEUE_LOWER_PENALTY if you are so inclined :-) but that can always be added later if need be.


Line 33: ;   After 30 seconds, Agent 2's priority is bumped to 2 by the penaltychange, so both agents are treated equally.
s/Agent 2/Agent 1


-- 
To view, visit https://gerrit.asterisk.org/5623
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1c6421a983667a5ac4c359f6dac25b212b4c459
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Steve Davies <steve at one47.co.uk>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes