[Asterisk-code-review] res pjsip session : fixed wrong From Header number On Re-invite (asterisk[master])

Joshua Colp asteriskteam at digium.com
Wed May 10 06:06:43 CDT 2017


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5535 )

Change subject: res_pjsip_session : fixed wrong From Header number On Re-invite
......................................................................


Patch Set 1:

I'm personally thinking that in the case of a re-invite we shouldn't modify the From header at all, it should be kept the same as it is as some devices may react incorrectly and thus your change makes sense to me. I'm going to have others provide their feedback too.

-- 
To view, visit https://gerrit.asterisk.org/5535
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55a9caa7dc90e6c4c219cb09b5c2ec08af84a302
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Yasin CANER <yasin.caner at netgsm.com.tr>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Yasin CANER <yasin.caner at netgsm.com.tr>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list