[Asterisk-code-review] SDP: Explicitly stop a RTP instance before destoying it. (asterisk[master])

Richard Mudgett asteriskteam at digium.com
Tue May 9 13:02:00 CDT 2017


Hello Jenkins2, Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/5598

to look at the new patch set (#2).

Change subject: SDP: Explicitly stop a RTP instance before destoying it.
......................................................................

SDP: Explicitly stop a RTP instance before destoying it.

* Made sdp_add_m_from_rtp_stream() and sdp_add_m_from_udptl_stream()
handle generating disabled/declined streams.

* Added /main/sdp/sdp_merge_asymmetric unit test.  It currently does not
check the offerer side negotiated SDP because that isn't the purpose of
this patch and there is much to be done to handle declined/dummy streams.

* Added T.38 image streams to the /main/sdp/sdp_merge_symmetric and
/main/sdp/sdp_merge_crisscross unit tests.

Change-Id: Ib4dcb3ca4f9a9133b376f4e3302f9a1f963f2b31
---
M include/asterisk/stream.h
M main/sdp_state.c
M tests/test_sdp.c
3 files changed, 438 insertions(+), 188 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/98/5598/2
-- 
To view, visit https://gerrit.asterisk.org/5598
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib4dcb3ca4f9a9133b376f4e3302f9a1f963f2b31
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list