[Asterisk-code-review] SDP: Change media address to specify our address to use. (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5594 )

Change subject: SDP: Change media_address to specify our address to use.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5594/1//COMMIT_MSG
Commit Message:

Line 9: When we optionally set the media_address we are forcing the media to go
> This is incorrect and changing the meaning of this option. The option media
This was done because of ASTERISK-26851.  Otherwise we would not be able to setup the rtp instance the same way before it was started.  The PJSIP option is handled when setting up the sdp_options to determine what to put as the media_address.

I thought that the bind_rtp_to_media_address guarded the media_address value.  I now see that create_local_sdp() uses the value directly regardless of the bind_rtp_to_media_address option.


-- 
To view, visit https://gerrit.asterisk.org/5594
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I160d9fac322a075bd2557b430632544178196189
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes