[Asterisk-code-review] app confbridge: Fix reference to cfg in menu template handler (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5579 )

Change subject: app_confbridge:  Fix reference to cfg in menu_template_handler
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/5579/1/apps/confbridge/conf_config_parser.c
File apps/confbridge/conf_config_parser.c:

Line 2025: 	/*
> I don't believe this is correct. The old code pulled information from the p
The call to get the pending config is wrong.  The user and bridge template handlers get the current global config obj.  It also looks like a copy-paste err where the line was copied from verify_default_profiles().

Also you cannot use the "template" option in a config file.  It is only valid with the CONFBRIDGE dialplan function.


https://gerrit.asterisk.org/#/c/5579/2/apps/confbridge/conf_config_parser.c
File apps/confbridge/conf_config_parser.c:

Line 2030: 	RAII_VAR(struct confbridge_cfg *, cfg, ao2_bump(aco_pending_config(&cfg_info)), ao2_cleanup);
This really should be a call to ao2_global_obj_ref().  See my comment on version 1 of the patch in response to josh.


https://gerrit.asterisk.org/#/c/5579/2/main/config_options.c
File main/config_options.c:

PS2, Line 590: 	ao2_cleanup(info->internal->pending);
             : 	return ACO_PROCESS_OK;
Need to clear pending here too.


-- 
To view, visit https://gerrit.asterisk.org/5579
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib349a17d3d088f092480b19addd7122fcaac21a7
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes