[Asterisk-code-review] Prevent Undefined Capath Crash (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5583 )

Change subject: Prevent Undefined Capath Crash
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5583/1/main/tcptls.c
File main/tcptls.c:

Line 950: 		cfg->capath = NULL;
Setting cfg->capath to NULL will actually cause the crash you saw.  This pointer is not supposed to ever be NULL.  It is supposed to point to allocated memory.  If it isn't configured it should have a non-NULL pointer returned by ast_strdup("").

You may have actually has a memory allocation failure that wasn't caught when the pointer was initialized.


-- 
To view, visit https://gerrit.asterisk.org/5583
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63ff715d9d9023427543a5b8a4ba7b0d82533c12
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Elson <joshelson at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes