[Asterisk-code-review] app confbridge: Fix non-reference to cfg in menu template h... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5579 )

Change subject: app_confbridge:  Fix non-reference to cfg in menu_template_handler
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5579/1//COMMIT_MSG
Commit Message:

Line 14: ASTERISK-26605 #close
This is the wrong issue.


https://gerrit.asterisk.org/#/c/5579/1/apps/confbridge/conf_config_parser.c
File apps/confbridge/conf_config_parser.c:

Line 2025: 	RAII_VAR(struct confbridge_cfg *, cfg, ao2_global_obj_ref(cfg_handle), ao2_cleanup);
I don't believe this is correct. The old code pulled information from the pending configuration, the new code pulls it from the active configuration. If something existed in the new config but not in the old one, this would incorrectly fail or would get the wrong data.


-- 
To view, visit https://gerrit.asterisk.org/5579
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib349a17d3d088f092480b19addd7122fcaac21a7
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes