[Asterisk-code-review] bridge simple: Added support for streams (asterisk[master])

Kevin Harwell asteriskteam at digium.com
Wed May 3 16:36:28 CDT 2017


Hello Mark Michelson, George Joseph, Jenkins2, Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/5528

to look at the new patch set (#7).

Change subject: bridge_simple: Added support for streams
......................................................................

bridge_simple: Added support for streams

This patch is the first cut at adding stream support to the bridging framework.
Changes were made to the framework that allows mapping of stream topologies to
a bridge's supported media types.

The first channel to enter a bridge initially defines the media types for a
bridge (i.e. a one to one mapping is created between the bridge and the first
channel). Subsequently added channels merge their media types into the bridge's
adding to it when necessary. This allows channels with different sized
topologies to map correctly to each other according to media type. The bridge
drops any frame that does not have a matching index into a given write stream.

For now though, bridge_simple will align its two channels according to size or
first to join. Once both channels join the bridge the one with the most streams
will indicate to the other channel to update its streams to be the same as that
of the other. If both channels have the same number of streams then the first
channel to join is chosen as the stream base.

A topology change source was also added to a channel when a stream toplogy
change request is made. This allows subsystems to know whether or not they
initiated a change request. Thus avoiding potential recursive situations.

ASTERISK-26966 #close

Change-Id: I1eb5987921dd80c3cdcf52accc136393ca2d4163
---
M bridges/bridge_simple.c
M include/asterisk/bridge.h
M include/asterisk/bridge_channel.h
M include/asterisk/bridge_technology.h
M include/asterisk/channel.h
M include/asterisk/channel_internal.h
M include/asterisk/stream.h
M main/bridge.c
M main/bridge_channel.c
M main/channel.c
M main/channel_internal_api.c
M main/stream.c
M tests/test_stream.c
13 files changed, 348 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/28/5528/7
-- 
To view, visit https://gerrit.asterisk.org/5528
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1eb5987921dd80c3cdcf52accc136393ca2d4163
Gerrit-PatchSet: 7
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list