[Asterisk-code-review] res pjsip session : add a function to manipulating toHeader ... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5545 )

Change subject: res_pjsip_session : add a function to manipulating toHeader number
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/#/c/5545/1/apps/app_dial.c
File apps/app_dial.c:

PS1, Line 2605: 		if(ast_channel_dialed(chan)->number.str){
              : 			ast_party_dialed_copy(ast_channel_dialed(tc),ast_channel_dialed(chan));
              : 		}
This needs some spacing changes to fit in with the other code. As well - does this impact other channel drivers or CDRs?


https://gerrit.asterisk.org/#/c/5545/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

Line 892:         ast_party_dialed_set(&dialed, ast_channel_dialed(session->channel));
This leaks memory. It needs to be freed using ast_party_dialed_free.


Line 893:         if(!dialed.number.str){
Need a space in between the "if" and (


Line 902:         pj_strdup2(dlg_pool, &dlg_info_uri->user,ast_channel_dialed(session->channel)->number.str);
Need a space after the "," and before "ast_channel_dialed"


Line 1275: 	set_to_header(session);
What impact does this have on reinvites? Is the To header correct in that case?


-- 
To view, visit https://gerrit.asterisk.org/5545
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77261b6e6e7962f7371b91d78b8124af050cab61
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Yasin CANER <yasin.caner at netgsm.com.tr>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes