[Asterisk-code-review] res rtp asterisk: Clearing the remote RTCP address causes RT... (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5564 )

Change subject: res_rtp_asterisk: Clearing the remote RTCP address causes RTCP failures
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5564/3/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 5717: 	 * Do not clear the RTP or RTCP remote address here. We may
I don't think not setting the instance remote address is correct here. Previously this would set the remote address to null, and in res_rtp_asterisk the instance remote address is retrieved for sending packets. This would result in outgoing traffic being dropped. Now since you've removed it this will result in traffic going out, when it shouldn't.


-- 
To view, visit https://gerrit.asterisk.org/5564
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6be200fb20db647e48b5138ea4b81dfa7962974b
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes