[Asterisk-code-review] res pjsip session : fixed wrong From Header number On Re-invite (asterisk[master])

[Yasin CANER]

Yasin CANER has posted comments on this change. ( https://gerrit.asterisk.org/5535 )

Change subject: res_pjsip_session : fixed wrong From Header number On Re-invite
......................................................................


Patch Set 1:

> This change originally went in as part of work to add Anonymous
 > support to chan_pjsip. I think by removing this call that will
 > break Anonymous support. The proper fix would be to examine
 > set_from_header for this particular scenario and determine if it
 > needs to be adjusted to produce the From header differently for it.

  i tested the code again. From header number creating from effective_id in channel at set_from_header func. if it is only anonymous support , can we split anonymous support from set_from_header function? . i think it is easy way to solve it and it stops making big problems , isnt it?
if you want , i can do it.
cheers.

-- 
To view, visit https://gerrit.asterisk.org/5535
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55a9caa7dc90e6c4c219cb09b5c2ec08af84a302
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Yasin CANER <yasin.caner at netgsm.com.tr>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Yasin CANER <yasin.caner at netgsm.com.tr>
Gerrit-HasComments: No