[Asterisk-code-review] res rtp asterisk: Clearing the remote RTCP address causes RT... (asterisk[14])

George Joseph asteriskteam at digium.com
Tue May 2 14:42:37 CDT 2017


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5565 )

Change subject: res_rtp_asterisk: Clearing the remote RTCP address causes RTCP failures
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5565/2/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

PS2, Line 5717: 	/*
              : 	 * Do not clear the remote address (rtcp->them) here. We may
              : 	 * continue to receive rtcp from the remote.
              : 	 */
I'd say "Don't clear the rtp or rtcp remote addresses here"...


-- 
To view, visit https://gerrit.asterisk.org/5565
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6be200fb20db647e48b5138ea4b81dfa7962974b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list