[Asterisk-code-review] res rtp asterisk: Clearing the remote RTCP address causes RT... (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/5564 )

Change subject: res_rtp_asterisk: Clearing the remote RTCP address causes RTCP failures
......................................................................


Patch Set 2:

> That's a good point though, by not setting the remote address are we then still sending media when we shouldn't be?

I don't think so. I initially wondered the same thing, but looking at "ast_rtp_remote_address_set" it only sets the rtp_instance local address if the incoming "addr" is not NULL. Which in this case it is. Otherwise it only sets the rtp->rtcp remote address (rtcp->them).

So basically before removing the call to it was only setting rtcp->rtcp->them to NULL.

-- 
To view, visit https://gerrit.asterisk.org/5564
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6be200fb20db647e48b5138ea4b81dfa7962974b
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: No