[Asterisk-code-review] channel: Remove old epoll support and fixed max number of fi... (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/5283 )

Change subject: channel: Remove old epoll support and fixed max number of file descriptors.
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5283/3/main/channel.c
File main/channel.c:

Line 91
Probably need to ditch this structure as well, no?


https://gerrit.asterisk.org/#/c/5283/3/main/channel_internal_api.c
File main/channel_internal_api.c:

Line 1451: int ast_channel_fd_count(const struct ast_channel *chan)
Gotta still go look where this is used, but isn't this really how large the fd vector is, which could be sparse (i.e. have a pile of -1 entries) instead of how many legitimate fds are on the channel?


-- 
To view, visit https://gerrit.asterisk.org/5283
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a754b506c009b83dfdeeb08c2d2815db30ef928
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes