[Asterisk-code-review] res xmpp: Use incremental backoff when a read error occurs (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5290 )

Change subject: res_xmpp: Use incremental backoff when a read error occurs
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5290/1/res/res_xmpp.c
File res/res_xmpp.c:

Line 3779: 	/* We only allow cancellation while sleeping */
> Why only allow cancellation while sleeping?
Specifically because of the RAII_VAR used in the thread function. If we cancel in the middle of that block, the __cleanup__ functions are not run.


-- 
To view, visit https://gerrit.asterisk.org/5290
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fe10ef4734837727437beab715e336777f13f48
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes