[Asterisk-code-review] res pjsip endpoint identifier ip: Add an option to match req... (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/5192 )

Change subject: res_pjsip_endpoint_identifier_ip: Add an option to match requests by header
......................................................................


Patch Set 1: Code-Review+2

> Looks fine to me, so I'll go ahead and +1, but could you foresee
 > any case where matching against multiple headers might make sense?

If you're matching on a particular header, it is most likely that you are going to match on some custom header that something within your domain of control has added to the request. Thus, it's likely that

1) You have not added more than one instance of this header, and
2) You will only need to match on the one instance of this header.

If someone tries to do something like match on a Via header (of which there can be multiple)...then they're doing a silly silly thing. Until someone can show that there's a legit use case for something like that, I think Matt's approach here is fine.

-- 
To view, visit https://gerrit.asterisk.org/5192
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc14835c962f92e35e67bbdb235cf0589de5453
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: No