[Asterisk-code-review] pbx spool: Set AST OUTGOING ATTEMPT variable on channel (asterisk[master])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5132 )

Change subject: pbx_spool: Set AST_OUTGOING_ATTEMPT variable on channel
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5132/2/pbx/pbx_spool.c
File pbx/pbx_spool.c:

Line 333: 	if (ast_asprintf(&attempt, "%d", o->retries + 1) >= 0) {
Use snprintf with buf instead.  That way you don't need to allocate and free memory.  buf is plenty big enough to accommodate a int string.


-- 
To view, visit https://gerrit.asterisk.org/5132
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd7e8d43b0ed5b6cb021c62f41f1a1f5733dd89
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes