[Asterisk-code-review] res/pjsip Add test for 'auto info' (testsuite[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5878 )

Change subject: res/pjsip  Add test for 'auto_info'
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/run-test
File tests/channels/pjsip/dtmf_info_fallback/run-test:

https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/run-test@25
PS3, Line 25: sippA_logfile = WORKING_DIR + "/A_PARTY.log"
            : sippA_errfile = WORKING_DIR + "/A_PARTY_ERR.log"
            : sippB_logfile = WORKING_DIR + "/B_PARTY.log"
            : sippB_errfile = WORKING_DIR + "/B_PARTY_ERR.log"
These cause the working tree to be polluted.


https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/run-test@29
PS3, Line 29: SIPP_SCENARIOS = [
            :     {
            :         'scenario' : 'B_PARTY.xml',
            :         '-i' : '127.0.0.1',
            :         '-p' : '5700',
            :         '-mp' : '6300',
            :         '-message_file' : sippB_logfile,
            :         '-error_file' : sippB_errfile,
            :         '-trace_msg' : '-trace_err',
            :     },
            :     {
            :         'scenario' : 'A_PARTY.xml',
            :         '-i' : '127.0.0.1',
            :         '-p' : '6060',
            :         '-s' : '3228080970',
            :         '-d' : '35000',
            :         '-message_file' : sippA_logfile,
            :         '-error_file' : sippA_errfile,
            :         '-trace_msg' : '-trace_err',
            :     }
            : ]
Why not just do this in the test-config.yaml file?


https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/run-test@56
PS3, Line 56: 	
whitespace


https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/test-config.yaml
File tests/channels/pjsip/dtmf_info_fallback/test-config.yaml:

https://gerrit.asterisk.org/#/c/5878/3/tests/channels/pjsip/dtmf_info_fallback/test-config.yaml@7
PS3, Line 7:     minversion: '13.16.0'
           :     dependencies:
           :         - app : 'sipp'
           :     tags:
           :         - SIP
This would be better...

properties:
    minversion: [ '13.17.0', '14.6.0' ]
    dependencies:
        - app : 'sipp'
        - asterisk : 'res_pjsip'
    tags:
        - pjsip



-- 
To view, visit https://gerrit.asterisk.org/5878
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I674d3a6dc678f275bb39738505ee032dd86dbb37
Gerrit-Change-Number: 5878
Gerrit-PatchSet: 3
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Thu, 29 Jun 2017 12:58:39 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170629/899e5801/attachment.html>