[Asterisk-code-review] chan pjsip: Add support for multiple streams of the same type. (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/5876 )

Change subject: chan_pjsip: Add support for multiple streams of the same type.
......................................................................


Patch Set 12: Code-Review-1

(2 comments)

See comment - still going through code though.

https://gerrit.asterisk.org/#/c/5876/11/main/stream.c
File main/stream.c:

https://gerrit.asterisk.org/#/c/5876/11/main/stream.c@311
PS11, Line 311: 		if (!ast_format_cap_identical(ast_stream_get_formats(left_stream), ast_stream_get_formats(right_stream))) {
Is it possible for ast_stream_get_formats() to return NULL here?


https://gerrit.asterisk.org/#/c/5876/12/main/stream.c
File main/stream.c:

https://gerrit.asterisk.org/#/c/5876/12/main/stream.c@311
PS12, Line 311: 		if (!ast_format_cap_identical(ast_stream_get_formats(left_stream), ast_stream_get_formats(right_stream))) {
Could ast_stream_get_formats() potentially return null here?



-- 
To view, visit https://gerrit.asterisk.org/5876
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8afd8dd2eb538806a39b887af0abd046266e14c7
Gerrit-Change-Number: 5876
Gerrit-PatchSet: 12
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 23 Jun 2017 19:49:43 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170623/6d55fafe/attachment.html>