[Asterisk-code-review] bridge: stuck channel(s) after failed attended transfer (asterisk[13])

Joshua Colp asteriskteam at digium.com
Wed Jun 21 17:36:56 CDT 2017


Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/5892 )

Change subject: bridge: stuck channel(s) after failed attended transfer
......................................................................

bridge: stuck channel(s) after failed attended transfer

If an attended transfer failed it was possible for some of the channels
involved to get "stuck" because Asterisk was not hanging up the transfer target.

This patch ensures Asterisk hangs up the transfer target when an attended
transfer failure occurs.

ASTERISK-27075 #close

Change-Id: I98a6ecd92d3461ab98c36f0d9451d23adaf3e5f9
---
M main/bridge.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  Richard Mudgett: Looks good to me, approved



diff --git a/main/bridge.c b/main/bridge.c
index b2beb86..63d6e11 100644
--- a/main/bridge.c
+++ b/main/bridge.c
@@ -4787,7 +4787,7 @@
 	res = AST_BRIDGE_TRANSFER_SUCCESS;
 
 end:
-	if (res == AST_BRIDGE_TRANSFER_SUCCESS && hangup_target) {
+	if ((res == AST_BRIDGE_TRANSFER_SUCCESS && hangup_target) || res == AST_BRIDGE_TRANSFER_FAIL) {
 		ast_softhangup(to_transfer_target, AST_SOFTHANGUP_DEV);
 	}
 

-- 
To view, visit https://gerrit.asterisk.org/5892
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: I98a6ecd92d3461ab98c36f0d9451d23adaf3e5f9
Gerrit-Change-Number: 5892
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170621/c203b500/attachment.html>


More information about the asterisk-code-review mailing list