[Asterisk-code-review] core local: local channel data not being properly unref'ed a... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5888 )

Change subject: core_local: local channel data not being properly unref'ed and unlocked
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5888/1/main/core_local.c
File main/core_local.c:

https://gerrit.asterisk.org/#/c/5888/1/main/core_local.c@238
PS1, Line 238: void ast_local_lock_all2(struct ast_channel *chan, void **tech_pvt, void **base_pvt,
             : 		struct ast_channel **base_chan, struct ast_channel **base_owner)
You don't need to save both tech_pvt and base_pvt since they must always point to the same place.  It is a requirement of subclassing the unreal channels that the base pvt struct be the first member of the subclass.


https://gerrit.asterisk.org/#/c/5888/1/main/core_local.c@265
PS1, Line 265: void ast_local_unlock_all2(struct ast_channel *chan, void *tech_pvt, void *base_pvt,
             : 		struct ast_channel *base_chan, struct ast_channel *base_owner)
chan is not needed to pass in.
only tech_pvt or base_pvt is needed since they always point to the same place.



-- 
To view, visit https://gerrit.asterisk.org/5888
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ice96653e29bd9d6674ed5f95feb6b448ab148b09
Gerrit-Change-Number: 5888
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 21 Jun 2017 15:42:39 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170621/f139b816/attachment-0001.html>