[Asterisk-code-review] res pjsip mwi: update unsolicited MWI subscriptions on updat... (asterisk[14])

[Alexei Gradinari]

Alexei Gradinari has uploaded this change for review. ( https://gerrit.asterisk.org/5883


Change subject: res_pjsip_mwi: update unsolicited MWI subscriptions on updating contact
......................................................................

res_pjsip_mwi: update unsolicited MWI subscriptions on updating contact

Do not need to unsubscribe/subscribe on creating the ednpoint's contact.
The modified function create_mwi_subscriptions_for_endpoint adds
the subscription only if it does not exist.

The subscriptions aren't added for active contacts
which are retrieved on startup from realtime
if mwi_disable_initial_unsolicited=yes.
Because the mwi_contact_added is not called.
So the subscriptions also should be created on updating contact.

ASTERISK-26230 #close

Change-Id: I47e265af9296ca09aa42a316fdacac104148cee4
---
M res/res_pjsip_mwi.c
1 file changed, 38 insertions(+), 31 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/83/5883/1

diff --git a/res/res_pjsip_mwi.c b/res/res_pjsip_mwi.c
index 3dfccef..630349f 100644
--- a/res/res_pjsip_mwi.c
+++ b/res/res_pjsip_mwi.c
@@ -1097,11 +1097,18 @@
 	struct ast_sip_endpoint *endpoint = obj;
 	char *mailboxes, *mailbox;
 
-	if (ast_strlen_zero(endpoint->subscription.mwi.mailboxes)) {
+	if (!endpoint || ast_strlen_zero(endpoint->subscription.mwi.mailboxes)) {
 		return 0;
 	}
 
 	if (endpoint->subscription.mwi.aggregate) {
+		const char *endpoint_id = ast_sorcery_object_get_id(endpoint);
+
+		/* Check if subscription exists */
+		aggregate_sub = ao2_find(unsolicited_mwi, endpoint_id, OBJ_SEARCH_KEY | OBJ_NOLOCK);
+		if (aggregate_sub) {
+			return 0;
+		}
 		aggregate_sub = mwi_subscription_alloc(endpoint, 0, NULL);
 		if (!aggregate_sub) {
 			return 0;
@@ -1113,7 +1120,9 @@
 		struct mwi_subscription *sub;
 		struct mwi_stasis_subscription *mwi_stasis_sub;
 
-		if (ast_strlen_zero(mailbox)) {
+		/* check if subscription exists */
+		if (ast_strlen_zero(mailbox) ||
+			(!aggregate_sub && endpoint_receives_unsolicited_mwi_for_mailbox(endpoint, mailbox))) {
 			continue;
 		}
 
@@ -1189,44 +1198,42 @@
 	return 0;
 }
 
-/*! \brief Function called when a contact is updated */
-static void mwi_contact_updated(const void *object)
-{
-	char *id = ast_strdupa(ast_sorcery_object_get_id(object)), *aor = NULL;
+/*! \brief Create mwi subscriptions and notify */
+static void mwi_contact_changed(const struct ast_sip_contact *contact) {
+	char *id = ast_strdupa(ast_sorcery_object_get_id(contact)), *aor = NULL;
+	RAII_VAR(struct ast_sip_endpoint *, endpoint, NULL, ao2_cleanup);
+
+	if (contact->endpoint) {
+		endpoint = ao2_bump(contact->endpoint);
+	} else {
+		if (!ast_strlen_zero(contact->endpoint_name)) {
+			endpoint = ast_sorcery_retrieve_by_id(ast_sip_get_sorcery(), "endpoint", contact->endpoint_name);
+		}
+	}
+
+	if (!endpoint || ast_strlen_zero(endpoint->subscription.mwi.mailboxes)) {
+		return;
+	}
+
+	ao2_lock(unsolicited_mwi);
+	create_mwi_subscriptions_for_endpoint(endpoint, NULL, 0);
+	ao2_unlock(unsolicited_mwi);
 
 	aor = strsep(&id, ";@");
 
 	ao2_callback(unsolicited_mwi, OBJ_NODATA, send_contact_notify, aor);
 }
 
+/*! \brief Function called when a contact is updated */
+static void mwi_contact_updated(const void *object)
+{
+	mwi_contact_changed(object);
+}
+
 /*! \brief Function called when a contact is added */
 static void mwi_contact_added(const void *object)
 {
-	const struct ast_sip_contact *contact = object;
-	struct ao2_iterator *mwi_subs;
-	struct mwi_subscription *mwi_sub;
-	const char *endpoint_id = ast_sorcery_object_get_id(contact->endpoint);
-
-	if (ast_strlen_zero(contact->endpoint->subscription.mwi.mailboxes)) {
-		return;
-	}
-
-	ao2_lock(unsolicited_mwi);
-
-	mwi_subs = ao2_find(unsolicited_mwi, endpoint_id,
-		OBJ_SEARCH_KEY | OBJ_MULTIPLE | OBJ_NOLOCK | OBJ_UNLINK);
-	if (mwi_subs) {
-		for (; (mwi_sub = ao2_iterator_next(mwi_subs)); ao2_cleanup(mwi_sub)) {
-			unsubscribe(mwi_sub, NULL, 0);
-		}
-		ao2_iterator_destroy(mwi_subs);
-	}
-
-	create_mwi_subscriptions_for_endpoint(contact->endpoint, NULL, 0);
-
-	ao2_unlock(unsolicited_mwi);
-
-	mwi_contact_updated(object);
+	mwi_contact_changed(object);
 }
 
 /*! \brief Observer for contacts so unsolicited MWI is sent when a contact changes */

-- 
To view, visit https://gerrit.asterisk.org/5883
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: newchange
Gerrit-Change-Id: I47e265af9296ca09aa42a316fdacac104148cee4
Gerrit-Change-Number: 5883
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170619/3670cbbe/attachment.html>