[Asterisk-code-review] res corosync: Change thread stack size (asterisk[master])
Jan Friesse
asteriskteam at digium.com
Mon Jun 19 01:44:41 CDT 2017
Jan Friesse has posted comments on this change. ( https://gerrit.asterisk.org/5859 )
Change subject: res_corosync: Change thread stack size
......................................................................
Patch Set 1:
(1 comment)
> (1 comment)
Yes I can agree it looks like a lot, but calling stack can look like:
dispatch_thread_handler
cpg_dispatch (> 1MB stack allocated)
cpg_confchg_cb
send_cluster_notify
corosync_cfg_get_node_addrs (> 1MB stack allocated)
So strictly speaking 2MB + some room should be enough, but I've rather set 3MB just for sure.
https://gerrit.asterisk.org/#/c/5859/1/res/res_corosync.c
File res/res_corosync.c:
https://gerrit.asterisk.org/#/c/5859/1/res/res_corosync.c@86
PS1, Line 86: (AST_BACKGROUND_STACKSIZE + (3 * COROSYNC_IPC_BUFFER_SIZE)), \
> Is 3 MB necessary here? It seems excessive, IMHO. But maybe that's just m
Yes I can agree it looks like a lot, but calling stack can look like:
dispatch_thread_handler
cpg_dispatch (> 1MB stack allocated)
cpg_confchg_cb
send_cluster_notify
corosync_cfg_get_node_addrs (> 1MB stack allocated)
So strictly speaking 2MB + some room should be enough, but I've rather set 3MB just for sure.
--
To view, visit https://gerrit.asterisk.org/5859
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id95b0d21ab6e708e7d74ad8786c587211676fa08
Gerrit-Change-Number: 5859
Gerrit-PatchSet: 1
Gerrit-Owner: Jan Friesse <jfriesse at redhat.com>
Gerrit-Reviewer: Jan Friesse <jfriesse at redhat.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Mon, 19 Jun 2017 06:44:41 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170619/8b8420cf/attachment.html>
More information about the asterisk-code-review
mailing list