[Asterisk-code-review] res stasis: Plug reference leak on stolen channels (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5860 )

Change subject: res_stasis:  Plug reference leak on stolen channels
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5860/2/res/res_stasis.c
File res/res_stasis.c:

https://gerrit.asterisk.org/#/c/5860/2/res/res_stasis.c@1060
PS2, Line 1060: 	/* find control */
              : 	control = ao2_callback(app_controls, OBJ_UNLINK, masq_match_cb, old_chan);
We need a comment here saying we need to unlink because a
masquerade has changed the container key of the channel so normal finds won't find it anymore.

Also I removed a couple extraneous blank line changes.



-- 
To view, visit https://gerrit.asterisk.org/5860
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib820936cd49453f20156971785e7f4f182c56e14
Gerrit-Change-Number: 5860
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 16 Jun 2017 17:35:16 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170616/4855f752/attachment-0001.html>