[Asterisk-code-review] res pjsip session: Correct inverted test in session outgoin... (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5825 )

Change subject: res_pjsip_session:  Correct inverted test in session_outgoing_nat_hook
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5825/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/5825/1/res/res_pjsip_session.c@3125
PS1, Line 3125: 		if (!transport_state->localnet
              : 			|| (transport_state->localnet
              : 				&& ast_apply_ha(transport_state->localnet, &addr) != AST_SENSE_ALLOW)) {
The if statement can be simplified to:

 if (!transport_state->localnet || ast_apply_ha(...) != AST_SENSE_ALLOW)



-- 
To view, visit https://gerrit.asterisk.org/5825
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec617171eaa2d86d2680b00cf37d5088adafc27
Gerrit-Change-Number: 5825
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 14 Jun 2017 15:50:06 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170614/9e5ea062/attachment.html>