[Asterisk-code-review] format: Reintroduce smoother flags (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5731 )

Change subject: format: Reintroduce smoother flags
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/5731/2/main/format.c
File main/format.c:

PS2, Line 389: int ast_format_can_be_smoothed(const struct ast_format *format)
             : {
             : 	return format->codec->smooth;
             : }
> Any reason this was not coalesce to 1 if non-zero like the other 13 & 14 re
> Any reason this was not coalesce to 1 if non-zero like the other 13
 > & 14 reviews?

Because I split the smooth and smoother_flags into two separate fields. I only added it to the other branches in case some existing code somewhere was doing something silly like "if (whatever->smooth == 1)" instead of "if (whatever->smooth)"

I can use the same behavior here if it's an issue.


-- 
To view, visit https://gerrit.asterisk.org/5731
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77b835fba0e539c6ce50014a984766f63cab2c16
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes