[Asterisk-code-review] presence xml.c: PJSIP presence - incorrectly marked as CLOSED (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5749 )

Change subject: presence_xml.c: PJSIP presence - incorrectly marked as CLOSED
......................................................................


Patch Set 1: Code-Review-1

This change breaks the following tests as it changes the resulting messages:

tests/channels/pjsip/subscriptions/presence/presence_pidf
tests/channels/pjsip/subscriptions/presence/presence_xpidf

I don't think this is the correct fix either, as it breaks the xpidf implementation which can actually convey inuse. Looking at the chan_sip implementation the logic for the res_pjsip_pidf_body_generator module is slightly incorrect. It only puts open in the message if the local state is open. It should be open if the local state is open OR in use.

-- 
To view, visit https://gerrit.asterisk.org/5749
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1f4d1224d6c9b3fd8b01e6c708885e72f6a3a49
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Daniel Journo <dan at keshercommunications.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No