[Asterisk-code-review] pbx builtin: Properly handle hangup during Background (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5748 )

Change subject: pbx_builtin: Properly handle hangup during Background
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5748/1/main/pbx_builtins.c
File main/pbx_builtins.c:

Line 1119: 	exten[0] = res;
> I could be wrong but it looks like exten[0] was not previously set if AST_F
If AST_FLAG_DISABLE_WORKAROUNDS was set, exten[0] was not assigned and not used.

If AST_FLAG_DISABLE_WORKAROUNDS was not set, exten[0] was assigned and used.

Now it is assigned unconditionally and only used based on the AST_FLAG_DISABLE_WORKAROUNDS flag. The only difference now is that we might assign it unnecessarily, but I also think it is more clear to move the assignment outside of the conditional.

I'm happy to move it back if you think this will cause problems?


-- 
To view, visit https://gerrit.asterisk.org/5748
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ca6da93252d61c76ebdb46a4aa65e73ca985358
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes