[Asterisk-code-review] debug utilities: Add ast logescalator (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/4833 )

Change subject: debug_utilities:  Add ast_logescalator
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/4833/2/contrib/scripts/ast_logescalator
File contrib/scripts/ast_logescalator:

Line 15: 	$prog [ --help ] | [ [ --reset ] | [
Looks like an extra '[' before "--reset"


Line 395: 		sed -i -r -e "$(eval "echo s/core set ${x,,} .*/core set ${x,,} \$${x}_LEVEL/g")" "$CLI_CONF"  
red blob at end of line.


https://gerrit.asterisk.org/#/c/4833/2/res/res_pjsip_history.c
File res/res_pjsip_history.c:

Line 746: 	sprint_list_entry(entry, line, sizeof(line));
Should this line be here? It's unguarded by the log_level and if log_level != -1 then it appears it will be set twice.


-- 
To view, visit https://gerrit.asterisk.org/4833
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I799f8e5013b86dc5282961b27383d134bf09e543
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes