[Asterisk-code-review] ari: Implement 'debug all' and request/response logging (asterisk[certified/13.13])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/4750 )

Change subject: ari: Implement 'debug all' and request/response logging
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/4750/1/res/ari/cli.c
File res/ari/cli.c:

PS1, Line 331: 	app = ao2_callback_data(apps,
             : 		ast_strlen_zero(a->word) ? 0 : OBJ_PARTIAL_KEY,
             : 		complete_ari_app_search, (char*)a->word, &search);
Something is not correct here with the partial word completion. If I have ARI applications "foo" and "bar" registered, and I type "ari show app fo<tab>" I get "all", "foo", and "bar" as tab-completion options. That should just tab complete to "foo".

I think the problem is that complete_ari_app_search() is not doing anything with the arg parameter that is passed in.


https://gerrit.asterisk.org/#/c/4750/1/res/res_ari.c
File res/res_ari.c:

PS1, Line 1076: 	ast_verbose("<--- Sending ARI response to %s --->\n%d %s\n%s%s\n\n",
              : 		ast_sockaddr_stringify(&ser->remote_address), response.response_code,
              : 		response.response_text, ast_str_buffer(response.headers),
              : 		ast_str_buffer(response_body));
This should only be sent if debug is enabled for the app.


-- 
To view, visit https://gerrit.asterisk.org/4750
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief936f747ce47f1fb14035fbe61152cf766406bf
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes