[Asterisk-code-review] Adding tests that test forward error correction in codec opus (testsuite[master])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/4729 )

Change subject: Adding tests that test forward error correction in codec_opus
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

Just formatting stuff.

https://gerrit.asterisk.org/#/c/4729/1/tests/codecs/opus/fec/jitterbuffer/adaptive/sipp/invite.xml
File tests/codecs/opus/fec/jitterbuffer/adaptive/sipp/invite.xml:

PS1, Line 7:                        INVITE sip:bob@[remote_ip]:[remote_port] SIP/2.0
           :                         Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]
           :                         From: "alice" <sip:alice@[local_ip]:[local_port]>;tag=[call_number]
           :                         To: "bob" <sip:bob@[remote_ip]:[remote_port]>
           :                         Call-ID: [call_id]
           :                         CSeq: [cseq] INVITE
           :                         Contact: sip:alice@[local_ip]:[local_port]
           :                         Max-Forwards: 70
           :                         Content-Type: application/sdp
           :                         Content-Length: [len]
Like worrying political parties, this indentation is too far to the right.


Line 46:                         Allow: INVITE, ACK, MESSAGE, BYE
Here too


Line 64:                         Allow: INVITE, ACK, MESSAGE, BYE
And here.


https://gerrit.asterisk.org/#/c/4729/1/tests/codecs/opus/fec/jitterbuffer/fixed/sipp/invite.xml
File tests/codecs/opus/fec/jitterbuffer/fixed/sipp/invite.xml:

This file has the same indentation issues as pointed out on the previous SIPp scenario.


https://gerrit.asterisk.org/#/c/4729/1/tests/codecs/opus/fec/no_jitterbuffer/sipp/invite.xml
File tests/codecs/opus/fec/no_jitterbuffer/sipp/invite.xml:

THis file too


-- 
To view, visit https://gerrit.asterisk.org/4729
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia01a0432cc23071836d594c7c3dc46709c9880bf
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes