[Asterisk-code-review] app queue: add RINGNOANSWER event on caller hang up (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/4649 )

Change subject: app_queue: add RINGNOANSWER event on caller hang up
......................................................................


Patch Set 2: Code-Review-1

According to the documentation found here:

https://wiki.asterisk.org/wiki/display/AST/Queue+Logs

The RINGNOANSWER event is raised when the agent does not answer. This patch changes that. I'm worried that for some this may cause confusion as to who hung up or cause a problem with their filter/parsers. That being said I'm not completely against the change as it might be the best way to handle the problem.

If I've read the app_queue code correctly though there might be an alternative. It sounds like the agent name showing up on the ABANDON event would also be sufficient to solve your problem. 'wait_for_answer' can return the call attempt (instead of NULL) which should then contain the needed membername. 'try_calling' would then have to be modified to check to see if the caller hung up. If they did hang up and the return value is not null then you can raise the ABANDON event with the data you need. It looks like you'll also need to set qe.handled so the ABANDON even doesn't get fired twice at a later time.

Of course there may be side effects to that too, but I figured I'd throw it out there. Thoughts?

-- 
To view, visit https://gerrit.asterisk.org/4649
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic70f7b0f32fc95c9378e5bcf63865519014805d3
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: No