[Asterisk-code-review] abstract/fixed/adpative jitter buffer: disallow frame re-ins... (asterisk[14])

[Kevin Harwell]

Hello Mark Michelson, Anonymous Coward #1000019, Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/4713

to look at the new patch set (#2).

Change subject: abstract/fixed/adpative jitter buffer: disallow frame re-inserts
......................................................................

abstract/fixed/adpative jitter buffer: disallow frame re-inserts

It was possible for a frame to be re-inserted into a jitter buffer after it
had been removed from it. A case when this happened was if a frame was read
out of the jitterbuffer, passed to the translation core, and then multiple
frames were returned from said translation core. Upon multiple frames being
returned the first is passed on, but sebsequently "chained" frames are put
back into the read queue. Thus it was possible for a frame to go back into
the jitter buffer where this would cause problems.

This patch adds a flag to frames that are inserted into the channel's read
queue after translation. The abstract jitter buffer code then checks for this
flag and ignores any frames marked as such.

Change-Id: I276c44edc9dcff61e606242f71274265c7779587
---
M include/asterisk/abstract_jb.h
M include/asterisk/frame.h
M include/jitterbuf.h
M main/abstract_jb.c
M main/channel.c
M main/fixedjitterbuf.c
M main/fixedjitterbuf.h
M main/jitterbuf.c
8 files changed, 62 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/13/4713/2
-- 
To view, visit https://gerrit.asterisk.org/4713
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I276c44edc9dcff61e606242f71274265c7779587
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>