[Asterisk-code-review] debug utilities: Create ast loggrabber (asterisk[certified/13.13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/4724 )

Change subject: debug_utilities:  Create ast_loggrabber
......................................................................


Patch Set 1: Code-Review-1

(6 comments)

https://gerrit.asterisk.org/#/c/4724/1/contrib/scripts/ast_coredumper
File contrib/scripts/ast_coredumper:

PS1, Line 85: taraball
s/taraball/tarball


PS1, Line 87: but if you may want to use your own unique id in the
            : 		tarball names such as the Jira issue id.
Reads oddly.


PS1, Line 120: You must be root to use $prog.
Why require user to be root? What if I want someone to collect the information, but not give them root access to the whole system?


PS1, Line 182: $UID
This should probably be $EUID. $EUID expands to the effective user where as $UID expands to the current user.


https://gerrit.asterisk.org/#/c/4724/1/contrib/scripts/ast_loggrabber
File contrib/scripts/ast_loggrabber:

PS1, Line 47: taraball
s/taraball/tarball


PS1, Line 49: if you may want to use your own unique id in the
            : 		tarball names such as the Jira issue id.
This reads a bit odd.


-- 
To view, visit https://gerrit.asterisk.org/4724
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8bfe1468ada24c1344ce4abab7b002a59a659495
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes