[Asterisk-code-review] app queue: add RINGNOANSWER event on caller hang up (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/4649 )

Change subject: app_queue: add RINGNOANSWER event on caller hang up
......................................................................


Patch Set 1: Code-Review+1

> I was also concerned, but from my point of view it is a bug.
 > RINGNOANSWER is now created only in queue timeout. Before timeout
 > there is no info about ringing (which agent and how long was
 > ringing). I have put some examples to issue tracker.
 > It is still very dificult for me to write tests - I am quite new in
 > asterisk...

I understand.  I'm ok with this going into master, but due to lack of test coverage in app_queue, I don't feel comfortable putting this in 13 or 14.

-- 
To view, visit https://gerrit.asterisk.org/4649
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic70f7b0f32fc95c9378e5bcf63865519014805d3
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: No