[Asterisk-code-review] chan sip: Remember SDP negotiation on SIP CODEC INBOUND. (asterisk[14])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/4694 )

Change subject: chan_sip: Remember SDP negotiation on SIP_CODEC_INBOUND.
......................................................................


Patch Set 1: Code-Review+1

> The added line just *replaces* those formats already existing in
 > p->jointcaps. That line does not add or remove any formats.
 > Therefore, the content of the loop continues to survive. I am not
 > un-doing the loop.
 > 
 > Furthermore, I have to keep that cached part, because SIP_CODEC
 > could *add* formats not known before. That warning about the
 > negotiation mismatch should stay there.
 > 
 > If you still come to your conclusion, please, explain in greater
 > detail. Otherwise, please, remove that -1.

I was mistaken about what I thought ast_format_cap_replace_from_cap did, took another look at format_cap.c and I understand now.

-- 
To view, visit https://gerrit.asterisk.org/4694
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35712d98a793d4c3efdd156cec57deab9014b1dc
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: No