[Asterisk-code-review] app queue: add RINGNOANSWER event on caller hang up (asterisk[master])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/4649 )

Change subject: app_queue: add RINGNOANSWER event on caller hang up
......................................................................


Patch Set 1:

> This looks like it might change queue log behavior in that case
 > quite a bit.  That would be concerning to do in a release branch,
 > particularly with no tests.  Can you post a before and after queue
 > log example of what this patch does?

Sorry, I commented on the wrong branch - I'd be ok with the change in master, but I'm concerned about the cherry picks to 13 and 14 being different.  Can you show an example of what changes in the queue_log before and after this patch?

-- 
To view, visit https://gerrit.asterisk.org/4649
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic70f7b0f32fc95c9378e5bcf63865519014805d3
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: No