[Asterisk-code-review] res rtp asterisk.c: Initialize ourip passed to ast find ouri... (asterisk[master])

Mark Michelson asteriskteam at digium.com
Wed Jan 4 10:26:10 CST 2017


Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/4664 )

Change subject: res_rtp_asterisk.c: Initialize ourip passed to ast_find_ourip().
......................................................................


Patch Set 1: Code-Review+1

I've had a discussion with Richard, and the short version is that I'm going ahead and giving this a +1, and we'll create a separate issue to make ast_find_ourip() and ast_ouraddrfor() actually treat the output parameter as an output parameter, and clarify the contract that those functions implement.

-- 
To view, visit https://gerrit.asterisk.org/4664
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35507ea1ad7455d2be188f6ccdd4add7bd150e15
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Martin Tomec <tomec.martin at gmail.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list