[Asterisk-code-review] core/pbx: dialplan show - display filename/line# (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/4633 )

Change subject: core/pbx: dialplan show - display filename/line#
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

Minor inconsistency in the API documentation, otherwise this looks good to me.

https://gerrit.asterisk.org/#/c/4633/4/include/asterisk/pbx.h
File include/asterisk/pbx.h:

Line 1274: /*! 
Please delete this extra space when you fix doxygen below.


Line 1286:  * \retval 0 or positive integer indicating what line in the config file was responsible for
It appears this is no longer accurate, we are using '0' to represent NULL line number.  My preference is that we change this documentation, not the code.


-- 
To view, visit https://gerrit.asterisk.org/4633
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieccc6abccdff34ed5c7da3511fd24972b8f2dd30
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Jonathan R. Rose <jonathan.rose at motorolasolutions.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jonathan R. Rose <jonathan.rose at motorolasolutions.com>
Gerrit-Reviewer: Jonathan Rose <jrose at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes