[Asterisk-code-review] pjproject bundled: Compile pjsua with max log level = 2 (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4691 )

Change subject: pjproject_bundled:  Compile pjsua with max log level = 2
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/4691/1/third-party/pjproject/patches/config_site.h
File third-party/pjproject/patches/config_site.h:

Line 25: #ifndef NDEBUG
This change is useless.  NDEBUG is either defined or not and it doesn't matter what value it has.


PS1, Line 52: #ifndef PJ_DEBUG
            : #define PJ_DEBUG			0
            : #endif
PJ_DEBUG should just be removed from the config_site.h file.  It is the always defined opposite of NDEBUG and we don't need to define it.  Let the project's config.h file do it.


-- 
To view, visit https://gerrit.asterisk.org/4691
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2af9e7d48dde1927279c586c9c725d868fe6f3ff
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes