[Asterisk-code-review] stream: Unit tests for stream read and tweaks framework (asterisk[master])
Joshua Colp
asteriskteam at digium.com
Tue Feb 28 18:15:50 CST 2017
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5109 )
Change subject: stream: Unit tests for stream read and tweaks framework
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.asterisk.org/#/c/5109/2/main/channel.c
File main/channel.c:
PS2, Line 4015: /* Perform the framehook read event here. After the frame enters the framehook list
: * there is no telling what will happen, <insert mad scientist laugh here>!!! */
: f = ast_framehook_list_read_event(ast_channel_framehooks(chan), f);
Moving this here is a behavior change. Does that impact any framehook implementations?
--
To view, visit https://gerrit.asterisk.org/5109
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7792b20d782e71e823dabd3124572cf0a4caab2
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes
More information about the asterisk-code-review
mailing list