[Asterisk-code-review] res pjsip WebRTC/websockets: Fix usage of WS vs WSS. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Mon Feb 27 09:52:29 CST 2017


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/4973 )

Change subject: res_pjsip WebRTC/websockets: Fix usage of WS vs WSS.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/4973/2/CHANGES
File CHANGES:

PS2, Line 27:  * Removed non-secure websocket support.  Firefox and Chrome no longer allow
            :    non-secure websockets and pjproject doesn't support transports of the same
            :    name very well anyway.
This needs more explanation and clarification for users. What is the actual effect of this on users?


-- 
To view, visit https://gerrit.asterisk.org/4973
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a0fb1a41101a4c1e49d875a8aa87b189e7ab12
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jørgen H <asterisk.org at hovland.cx>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list