[Asterisk-code-review] res pjsip WebRTC/websockets: Fix usage of WS vs WSS. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/4973 )

Change subject: res_pjsip WebRTC/websockets: Fix usage of WS vs WSS.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/4973/2/res/res_pjsip_nat.c
File res/res_pjsip_nat.c:

PS2, Line 43: 		uri->transport_param.ptr = rdata->tp_info.transport->type_name;
            : 		uri->transport_param.slen = 2;
> Does this mean res_pjsip_nat has to be loaded for the URI parameter to be c
That question doesn't make sense.

This is a place where the type_name struct member is used for a URI.  Since that member gets set to WSS somewhere it might have that value here and thus should be fixed to be in compliance with the RFC.


-- 
To view, visit https://gerrit.asterisk.org/4973
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a0fb1a41101a4c1e49d875a8aa87b189e7ab12
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jørgen H <asterisk.org at hovland.cx>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes