[Asterisk-code-review] channel: Add ast read stream function for reading frames fro... (asterisk[master])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5079 )

Change subject: channel: Add ast_read_stream function for reading frames from all streams.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5079/2/include/asterisk/channel.h
File include/asterisk/channel.h:

PS2, Line 670: same stream), in standard format (see frame.h), from all
"same stream" and "all streams" seems to conflict.
Also, both read and read_stream have the same prototype so what differentiates them?


PS2, Line 1930: *!
              :  * \brief Reads a frame
              :  * \param chan channel to read a frame from
              :  * \return Returns a frame, or NULL on error.  If it returns NULL, you
              :  * best just stop reading frames and assume the channel has been
              :  * disconnected.
              :  */
              : struct ast_frame *ast_read(struct ast_channel *chan);
              : 
              : /*!
              :  * \brief Reads a frame, but does not filter to just the default streams
              :  * \param chan channel to read a frame from
              :  * \return Returns a frame, or NULL on error.  If it returns NULL, you
              :  * best just stop reading frames and assume the channel has been
              :  * disconnected.
              :  */
              : struct ast_frame *ast_read_stream(struct ast_channel *chan);
At first glance, since there's no difference in the prototypes, 
it's a little confusing.

Need more explanation of what each call does on multistream and non-multistream channels.


-- 
To view, visit https://gerrit.asterisk.org/5079
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5d7dc35e86694df91fd025126f6cfe0453aa38ce
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes