[Asterisk-code-review] res pjsip WebRTC/websockets: Fix usage of WS vs WSS. (asterisk[13])

[Richard Mudgett]

Hello Anonymous Coward #1000019, Joshua Colp, Jørgen H,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/4973

to look at the new patch set (#2).

Change subject: res_pjsip WebRTC/websockets: Fix usage of WS vs WSS.
......................................................................

res_pjsip WebRTC/websockets: Fix usage of WS vs WSS.

According to the RFC[1] WSS should be used in the Via header
for secure Websockets.

* Use WSS in Via for secure transport.

* Only register one transport with the WS name because it would be
ambiguous.  Outgoing requests may try to find the transport by name and
pjproject only finds the first one registered.  This may mess up unsecure
websockets but the impact should be minimal.  Firefox and Chrome do not
support anything other than secure websockets anymore.

* Added and updated some debug messages concerning websockets.

* security_events.c: Relax case restriction when determining security
transport type.

* res_pjsip_nat.c: Ensure that a rewritten URI sets the transport to ws if
the current transport name happens to be wss to comply with RFC[1].

[1] https://tools.ietf.org/html/rfc7118

ASTERISK-26796 #close

Change-Id: Ie3a0fb1a41101a4c1e49d875a8aa87b189e7ab12
---
M CHANGES
M res/res_pjsip/security_events.c
M res/res_pjsip_nat.c
M res/res_pjsip_transport_websocket.c
4 files changed, 56 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/73/4973/2
-- 
To view, visit https://gerrit.asterisk.org/4973
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie3a0fb1a41101a4c1e49d875a8aa87b189e7ab12
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jørgen H <asterisk.org at hovland.cx>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>